Prevent empty "description" from being sent with UMAPI

This closes #724
Netcentric · Jun 10, 2024 · 112cdf6 · 112cdf6
1 parent 5654dd4
commit 112cdf6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/...tool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ims/request/CreateGroupStep.java b/...tool-bundle/src/main/java/biz/netcentric/cq/tools/actool/ims/request/CreateGroupStep.java
@@ -6,7 +6,7 @@
 import com.fasterxml.jackson.annotation.JsonTypeName;
 
 @JsonTypeName("createUserGroup")
-@JsonInclude(Include.NON_NULL)
+@JsonInclude(Include.NON_EMPTY) // neither empty strings nor null values are allowed for "description", compare with https://github.com/Netcentric/accesscontroltool/issues/724
 public class CreateGroupStep implements Step {
 
     // this cannot be a constant, but still needs to be serialized as literal

diff --git a/...troltool-bundle/src/test/java/biz/netcentric/cq/tools/actool/ims/IMSUserManagementIT.java b/...troltool-bundle/src/test/java/biz/netcentric/cq/tools/actool/ims/IMSUserManagementIT.java
@@ -52,6 +52,12 @@ public HttpClientBuilder newBuilder() {
         AuthorizableConfigBean group2 = new AuthorizableConfigBean();
         group2.setAuthorizableId("testGroup");
         imsUserManagement.updateGroups(Collections.singleton(group2));
+
+        // test with empty description
+        AuthorizableConfigBean group3 = new AuthorizableConfigBean();
+        group3.setAuthorizableId("testGroup");
+        group3.setDescription("");
+        imsUserManagement.updateGroups(Collections.singleton(group3));
     }
 
     private static String getMandatoryEnvironmentVariable(String name) {