Revert proxy change #579
Merged
Revert proxy change #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveitaly
requested changes
Apr 22, 2023
spec/netsuite/configuration_spec.rb
Outdated
| @@ -519,21 +519,13 @@ | |||
| expect(config.proxy).to be_nil | |||
| end | |||
|
|
|||
| it 'does not pass in nil proxy to savon' do | |||
There was a problem hiding this comment.
can we keep this test? this is an important case to cover
spec/netsuite/configuration_spec.rb
Outdated
| connection = config.connection | ||
|
|
||
| expect(connection.globals.include?(:proxy)).to eql(true) | ||
| config.connection |
There was a problem hiding this comment.
I think we'd want to keep this case too
|
@andrewdicken-stripe friendly ping here! Would love to get this change in. |
|
@iloveitaly I made the change you requested, but for some reason the builds started failing. Not sure if there's an issue with the test suite because I had it working before and the changes that I made shouldn't have caused tall the issues I'm seeing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts recent proxy related change, explained further in issue here: #578. I'm not exactly sure why the proxy change breaks things but this fix should revert the behavior to how it was before.