Extend ideal interface

src/Ideal.jl

@@ -4,17 +4,38 @@
 #
 ###############################################################################
 
-function ideal
+# We assume that the function
+#   ideal(R::T, xs::Vector{U})
+# with U === elem_type(T) is implemented by anyone implementing ideals
+# for AbstractAlgebra rings.
+# The functions in this file extend the interface for `ideal`.
+
+function ideal(R::Ring, xs::AbstractVector{T}) where T<:RingElement
+  xs isa Vector{elem_type(R)} && error("ideals unsupported for ring $R")
+  return ideal(R, elem_type(R)[R(x) for x in xs])
 end
 
-function *(x::RingElement, R::Ring)
-  return ideal(R, x)
+function ideal(R::Ring, x::RingElement)
+  return ideal(R, elem_type(R)[R(x)])
 end
 
 function *(R::Ring, x::RingElement)
   return ideal(R, x)
 end
 
+function *(x::RingElement, R::Ring)
+  return ideal(R, x)
+end
+
+function ideal(x::RingElement)
+  return ideal(parent(x), x)
+end
+
+function ideal(xs::AbstractVector{T}) where T<:RingElement
+  !is_empty(xs) || throw(ArgumentError("Empty collection, cannot determine parent ring. Try ideal(ring, xs) instead of ideal(xs)"))
+  return ideal(parent(xs[1]), xs)
+end
+
 iszero(I::Ideal) = all(iszero, gens(I))
 
 base_ring_type(::Type{<:IdealSet{T}}) where T <: RingElement = parent_type(T)