Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename one further kernel method #1616

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Matrix.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4108,17 +4108,17 @@
################################################################################

@doc raw"""
kernel(A::MatElem{T}; R::Ring, side::Symbol = :right) where T <: RingElement
_kernel(A::MatElem{T}; R::Ring, side::Symbol = :right) where T <: RingElement

Return a tuple $(n, M)$, where $n$ is the rank of the kernel of $A$ over $R$ and $M$ is a
basis for it. If side is `:right` or not specified, the right kernel is
computed, i.e. the matrix of columns whose span gives the right kernel
space. If side is `:left`, the left kernel is computed, i.e. the matrix
of rows whose span is the left kernel space.
"""
function kernel(A::MatElem{T}, R::Ring; side::Symbol=:right) where T <: RingElement
function _kernel(A::MatElem{T}, R::Ring; side::Symbol=:right) where T <: RingElement

Check warning on line 4119 in src/Matrix.jl

View check run for this annotation

Codecov / codecov/patch

src/Matrix.jl#L4119

Added line #L4119 was not covered by tests
AR = change_base_ring(R, A)
return kernel(AR; side)
return _kernel(AR; side)

Check warning on line 4121 in src/Matrix.jl

View check run for this annotation

Codecov / codecov/patch

src/Matrix.jl#L4121

Added line #L4121 was not covered by tests
end

###############################################################################
Expand Down
Loading