Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Base.vec(M::MatElem) #1614

Closed
wants to merge 2 commits into from
Closed

Add Base.vec(M::MatElem) #1614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c4c5b8
Add `Base.vec(M::MatElem)`
lgoettgens Feb 19, 2024
de7a624
Update src/Matrix.jl
lgoettgens Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Matrix.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6789,6 +6789,22 @@ function Base.hvcat(rows::Tuple{Vararg{Int}}, A::MatrixElem{T}...) where T <: NC
return M
end

lgoettgens marked this conversation as resolved.
Show resolved Hide resolved
#to bypass the vec(collect(M)) which copies twice
function Base.vec(M::Generic.Mat)
return vec(M.entries)
end

function Base.vec(M::MatElem)
r = elem_type(base_ring(M))[]
sizehint!(r, nrows(M) * ncols(M))
for j=1:ncols(M)
for i=1:nrows(M)
push!(r, M[i, j])
end
end
return r
end

###############################################################################
#
# Change Base Ring
Expand Down
Loading