Remove error_dim_negative #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing uses it. Nemo defines its own version of this.
Codecov Report
@@ Coverage Diff @@
## master #1410 +/- ##
==========================================
- Coverage 85.84% 84.64% -1.21%
==========================================
Files 104 108 +4
Lines 28210 29455 +1245
==========================================
+ Hits 24217 24931 +714
- Misses 3993 4524 +531
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Breaking something upstream? |
|
Breaking something upstream? |
|
Indeed, in Nemo, but it defines its own So I guess this PR here is breaking (?) for now, until a new Nemo release with a fix is made (I'll submit a PR with such a fix shortly) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing uses it. Nemo defines its own version of this.