Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified interface for constructors containing variable names #1360

Merged
merged 128 commits into from
Nov 22, 2023
Merged

Unified interface for constructors containing variable names #1360

merged 128 commits into from
Nov 22, 2023

Commits on Oct 9, 2023

  1. Implement variable_names

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f5c9f35 View commit details
    Browse the repository at this point in the history

  2. Complete first draft

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    275409b View commit details
    Browse the repository at this point in the history

  3. Reorganize

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    52d930a View commit details
    Browse the repository at this point in the history

  4. Include VarNames.jl

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1340d02 View commit details
    Browse the repository at this point in the history

  5. Actually use @add_varnames_interface

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a81d130 View commit details
    Browse the repository at this point in the history

  6. Allow variable dims in @polynomial_ring ZZ x[v...]

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5f5c162 View commit details
    Browse the repository at this point in the history

  7. Purge old @polynomial_ring macro

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    eb1543c View commit details
    Browse the repository at this point in the history

  8. Add example for variable dims

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6c694b8 View commit details
    Browse the repository at this point in the history

  9. Simplify interface

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    16fa095 View commit details
    Browse the repository at this point in the history

  10. Work on special cases

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ae7ef3c View commit details
    Browse the repository at this point in the history

  11. Purge superfluous old constructors

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    538307f View commit details
    Browse the repository at this point in the history

  12. fix

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    dba232e View commit details
    Browse the repository at this point in the history

  13. fix

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    da55ef9 View commit details
    Browse the repository at this point in the history

  14. fix

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b5ce8e View commit details
    Browse the repository at this point in the history

  15. Add VarNames type

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f0ed25d View commit details
    Browse the repository at this point in the history

  16. Cleanup

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    071848c View commit details
    Browse the repository at this point in the history

  17. Revert to x1 instead of x[1]

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f721599 View commit details
    Browse the repository at this point in the history

  18. fix doctests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b3a811 View commit details
    Browse the repository at this point in the history

  19. fix doctest expectations

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3c51812 View commit details
    Browse the repository at this point in the history

  20. Fix some tests 

    Remove test on `polynomial_ring(::Ring, ::Tuple{Vararg{<:VarName}})`.
I introduced that variant and this test a few months ago for no good
reason. Get rid of it now.
    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b5d2e06 View commit details
    Browse the repository at this point in the history

  21. Make R[x...] equal polynomial_ring(R, x...)

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5b2b40f View commit details
    Browse the repository at this point in the history

  22. fix

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5d0e423 View commit details
    Browse the repository at this point in the history

  23. Fix doctest expectations

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1a6558f View commit details
    Browse the repository at this point in the history

  24. fix tests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5c6cf05 View commit details
    Browse the repository at this point in the history

  25. fix tests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    882d142 View commit details
    Browse the repository at this point in the history

  26. fix doctest expectations

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e90605e View commit details
    Browse the repository at this point in the history

  27. Use MacroTools

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a6af257 View commit details
    Browse the repository at this point in the history

  28. Change to 1:n syntax

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7db520a View commit details
    Browse the repository at this point in the history

  29. change ?: to if-else

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    371f925 View commit details
    Browse the repository at this point in the history

  30. towards introducing x0,x1,...

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ec33f3e View commit details
    Browse the repository at this point in the history

  31. Make it work

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    3610817 View commit details
    Browse the repository at this point in the history

  32. Add x# and x## syntax

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    99f5a68 View commit details
    Browse the repository at this point in the history

  33. Autodetect small indices in x# syntax

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    41a8873 View commit details
    Browse the repository at this point in the history

  34. Examples and x[%] syntax

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    4e8316f View commit details
    Browse the repository at this point in the history

  35. Use x# syntax to simplify example presentation

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8fe7ec1 View commit details
    Browse the repository at this point in the history

  36. Remove now disfunct example with x[variable]

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    da5a271 View commit details
    Browse the repository at this point in the history

  37. Update docstrings

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    dc62f65 View commit details
    Browse the repository at this point in the history

  38. Roughly include in docs

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2f337ec View commit details
    Browse the repository at this point in the history

  39. Add docstring for VarName

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    48f5834 View commit details
    Browse the repository at this point in the history

  40. Fix tests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    84ef57e View commit details
    Browse the repository at this point in the history

  41. Deprecate power_series_ring(R, weights, ...)

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    ff49194 View commit details
    Browse the repository at this point in the history

  42. Document @varnames_interface options

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7c4ecb0 View commit details
    Browse the repository at this point in the history

  43. typo

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    33c4508 View commit details
    Browse the repository at this point in the history

  44. typo

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8b5de4e View commit details
    Browse the repository at this point in the history

  45. No deprecations for now

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f9257f9 View commit details
    Browse the repository at this point in the history

  46. Add printf formatting

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    218288e View commit details
    Browse the repository at this point in the history

  47. typo

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    003e75a View commit details
    Browse the repository at this point in the history

  48. Fix docstring inclusions

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    baeb931 View commit details
    Browse the repository at this point in the history

  49. Clarify docstring

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    767948c View commit details
    Browse the repository at this point in the history

  50. Require at least one vararg

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    81fbcb4 View commit details
    Browse the repository at this point in the history

  51. lowercase laurent_polynomial_ring

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    da46e36 View commit details
    Browse the repository at this point in the history

  52. Compatibility with julia 1.6

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    8ef16c9 View commit details
    Browse the repository at this point in the history

  53. Pass on keyword arguments in macros

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    25e3122 View commit details
    Browse the repository at this point in the history

  54. Compatibility with julia 1.6

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    75a649e View commit details
    Browse the repository at this point in the history

  55. Fix bug in error string

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    bafd958 View commit details
    Browse the repository at this point in the history

  56. docstring change

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    635d38f View commit details
    Browse the repository at this point in the history

  57. One more julia 1.6 compatibility

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    45e515b View commit details
    Browse the repository at this point in the history

  58. remove done todo

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6c192bc View commit details
    Browse the repository at this point in the history

  59. Add more constructors

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    58db772 View commit details
    Browse the repository at this point in the history

  60. docs change

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2b2de20 View commit details
    Browse the repository at this point in the history

  61. Back to julia 1.6

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1f2d9d7 View commit details
    Browse the repository at this point in the history

  62. Minor cleanup

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a9afea1 View commit details
    Browse the repository at this point in the history

  63. Replace option n by two options n and range

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b5bfff0 View commit details
    Browse the repository at this point in the history

  64. Add missing kv...

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    09b54e0 View commit details
    Browse the repository at this point in the history

  65. Big clean up

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e7de8e1 View commit details
    Browse the repository at this point in the history

  66. Rearrange code

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e57eed9 View commit details
    Browse the repository at this point in the history

  67. Fix new doctests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    40e3ffb View commit details
    Browse the repository at this point in the history

  68. Fix new doctests

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    68d1235 View commit details
    Browse the repository at this point in the history

  69. Comment change

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    e47891d View commit details
    Browse the repository at this point in the history

  70. getindex needs at least one VarNames

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    86bcc4e View commit details
    Browse the repository at this point in the history

  71. Less options in variable_names

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7f9eb7e View commit details
    Browse the repository at this point in the history

  72. @f mimics f

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    de8fb99 View commit details
    Browse the repository at this point in the history

  73. Lowercase constructors in constructors.md 

    Co-authored-by: Max Horn <[email protected]>
    @mgkurtz @fingolfin
    mgkurtz and fingolfin authored Oct 9, 2023
    Configuration menu
    Copy the full SHA
    804c6a9 View commit details
    Browse the repository at this point in the history

  74. Lowercase constructors

    @mgkurtz
    mgkurtz committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    709a7f6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Lowercase rational_function_field

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    877624c View commit details
    Browse the repository at this point in the history

  2. Lowercase function_field

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    3f60bba View commit details
    Browse the repository at this point in the history

  3. Rewrite polynomial_ring docstring

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0982488 View commit details
    Browse the repository at this point in the history

  4. Rewrite polynomial_ring docstring

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e22d92f View commit details
    Browse the repository at this point in the history

  5. Rewrite polynomial_ring docstring

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8bca2ae View commit details
    Browse the repository at this point in the history

  6. Add polynomial_ring docstrings to docs

    @mgkurtz
    mgkurtz committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    8cf19a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Remove Printf dependency 

    Co-authored-by: Max Horn <[email protected]>
    @mgkurtz @fingolfin
    mgkurtz and fingolfin authored Oct 19, 2023
    Configuration menu
    Copy the full SHA
    de2df7a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Remove @Req

    @mgkurtz
    mgkurtz committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f6d240b View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch master into mgk/varnames

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c9c7f5a View commit details
    Browse the repository at this point in the history

  2. fix doctests to comply with Nemocas#1476

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f64ae2e View commit details
    Browse the repository at this point in the history

  3. Remove support for univariate methods

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    eaf8643 View commit details
    Browse the repository at this point in the history

  4. Undo cosmetic changes to rational_function_field

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    4498bbe View commit details
    Browse the repository at this point in the history

  5. factor out cleaning up

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    db9ce24 View commit details
    Browse the repository at this point in the history

  6. Undo cosmetic docs changes

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a82b416 View commit details
    Browse the repository at this point in the history

  7. Undo moving of some constructors

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d2424f0 View commit details
    Browse the repository at this point in the history

  8. Include RationalFunctionField.jl again

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cb65306 View commit details
    Browse the repository at this point in the history

  9. Keep old power_series_ring method

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cb7786c View commit details
    Browse the repository at this point in the history

  10. Update laurent_polynomial_ring docs

    @mgkurtz
    mgkurtz committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ff75348 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Revert "Revert "Fix printing multivariate polynomial ring with many v… 

    …ariables (Nemocas#1476)""
    @thofma @fingolfin
    thofma authored and fingolfin committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    98f1d7d View commit details
    Browse the repository at this point in the history

  2. warn about non-identifier names

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    571e9ef View commit details
    Browse the repository at this point in the history

  3. remove dated missing support

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6b94c8b View commit details
    Browse the repository at this point in the history

  4. For macro "x" works as "x#"

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    9c7d1f0 View commit details
    Browse the repository at this point in the history

  5. Also warn in @f(:x => -3,3)

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    664b358 View commit details
    Browse the repository at this point in the history

  6. Remove old char replacing function

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8415a30 View commit details
    Browse the repository at this point in the history

  7. Check indices to equal 1:n

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c4974ab View commit details
    Browse the repository at this point in the history

  8. Adapt to string indices

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    fef259e View commit details
    Browse the repository at this point in the history

  9. details

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    806b478 View commit details
    Browse the repository at this point in the history

  10. only check names in macros

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    bcf6cb7 View commit details
    Browse the repository at this point in the history

  11. fix

    @mgkurtz
    mgkurtz committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    702e421 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. fix

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    81c9025 View commit details
    Browse the repository at this point in the history

  2. cosmetics

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7808001 View commit details
    Browse the repository at this point in the history

  3. Use curly brackets for indices

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    417f93f View commit details
    Browse the repository at this point in the history

  4. fix doctests

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    664ce9d View commit details
    Browse the repository at this point in the history

  5. Merge branch th/revrevrev into mgk/varnames

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    00b8f0c View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Max Horn <[email protected]>
    @mgkurtz @fingolfin
    mgkurtz and fingolfin authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b80aaaf View commit details
    Browse the repository at this point in the history

  7. Changes from code review

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    1010a5c View commit details
    Browse the repository at this point in the history

  8. Docs changes

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    91c6fca View commit details
    Browse the repository at this point in the history

  9. Back to brackets

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    419eea7 View commit details
    Browse the repository at this point in the history

  10. fix

    @mgkurtz
    mgkurtz committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    43fb1b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Broaden test coverage

    @mgkurtz
    mgkurtz committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5620ca5 View commit details
    Browse the repository at this point in the history

  2. Complete code coverage

    @mgkurtz
    mgkurtz committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6388c3f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. fix for julia 1.6

    @mgkurtz
    mgkurtz committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    2225794 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Fix more issues reported by JET (Nemocas#1478)

    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    177a2e7 View commit details
    Browse the repository at this point in the history

  2. Replace multiple calls to precision(::AbsMSeries) (Nemocas#1481) 

    This function is type unstable, so at least internal code is better off not calling it
    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    23f0ac1 View commit details
    Browse the repository at this point in the history

  3. Remove redundant 'convert' invocation (Nemocas#1491) 

    There is already a type assertion inside the code, so no
need for this conversion inducing type declaration.
    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    90ae3e5 View commit details
    Browse the repository at this point in the history

  4. Resolve ambiguity between divexact methods (Nemocas#1484)

    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    cd7d8b8 View commit details
    Browse the repository at this point in the history

  5. Move stuff from Oscar to AbstractAlgebra (Nemocas#1494) 

    - add `@attributes` mutable struct MPolyRing
- generic `iszero` for ideals
- Dan's code for gcd, factor for nested polynomial rings
    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e97b991 View commit details
    Browse the repository at this point in the history

  6. Improve with_unicode (Nemocas#1495) 

    Some time ago `with_unicode` was improved in Oscar, apply that here.
    @fingolfin
    fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f6fa6c7 View commit details
    Browse the repository at this point in the history

  7. Enable more functionality for matrices of NCRing (Nemocas#1499)

    @lgoettgens @fingolfin
    lgoettgens authored and fingolfin committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7e73dd1 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Export new macros

    @fingolfin
    fingolfin committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    6ed8479 View commit details
    Browse the repository at this point in the history

  2. Update some comments

    @fingolfin
    fingolfin committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    017fbd2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into mgk/varnames

    @fingolfin
    fingolfin committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d0cf734 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Revert implementation for R[:x, :y] 

    Co-authored-by: Max Horn <[email protected]>
    @mgkurtz @fingolfin
    mgkurtz and fingolfin authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    704b29b View commit details
    Browse the repository at this point in the history

  2. fix tests

    @fingolfin
    fingolfin committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    181d615 View commit details
    Browse the repository at this point in the history