fix: Rev @crxjs/vite-plugin to properly include side_panel(s) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Increase @crxjs/vite-plugin to beta 18 for side_panel support.
|
Hello, thank you very much for your contribution! Everything looks good to me, except for one thing. Could you also add the content of the |
|
Actually I realized that just updating package*.json would only be half the solution. So I've updated the PR with the sample side_panel implementation I used to verify it all works. Hope this is helpful! |
NekitCorp
reviewed
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of this template predates the addition of side_panel support to the @crxjs/vite-plugin. Adjusting the version to the latest beta (18) fixes this and allows builds to properly include side_panel content.