Update OpenImageIO 2.5.7.0, Imath 3.1.11 and OpenEXR 3.2.3 to latest versions on Windows.

[TodicaIonut]

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

• I've followed the contributing guidelines to the best of my understanding
• I've read and understood the contributing guidelines
• I've formatted my code according to Natron's code style
• I've searched the pull requests tracker to ensure that this PR is not a duplicate

PR Description

What type of PR is this? (Check one of the boxes below)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
• Breaking change (fix or feature that would cause existing functionality to change)
• My change requires a change to the documentation
  • I have updated the documentation accordingly

What does this pull request do?

Upgrade to OpenImageIO 2.5

Have you tested your changes (if applicable)? If so, how?

Created a Windows release build with these new library versions and it appears to work fine.

[acolwell]

This is causing the "Build pacman repo" action to fail. It looks to be caused by the oiio-2.4.13.0-thread-shutdown.patch. You should be able to remove this patch since you are updating to 2.5.7, but you need to make sure that code in the openfx-io plugin still calls default_thread_pool_shutdown() when the plugin is unloaded. You can take a look at NatronGitHub/openfx-io@b194c3c to see the relevant code in openfx-io.

[TodicaIonut]

OpenEXR 3.2.3 (February 21, 2024)

[acolwell]

oiio-2.4.13.0-thread-shutdown.patch should be removed since it isn't being used anymore.

I do have a few questions though:
What is the motivation for this change?
Why did you pick 2.5.7 instead of the latest 2.5.8 release?
What testing have you done to verify that this has not broken anything?
What have you done to explicitly verify that the thread shutdown logic is still being called?
Why did you change the title to OpenEXR 3.2.3 when that release doesn't even exist yet and isn't being used here?

I must admit I have concerns about updating this non-trivial dependency without making sure there is extensive and thorough testing of many of the file types covered by this library. I do want to get us on a 2.5.x version, but we need to be careful and deliberate when doing so in my opinion.

[acolwell]

Please answer my questions. I am unlikely to approve this until you do.

[TodicaIonut]

Update:

• OpenImageIO 2.5.7.0
• Imath 3.1.11
• OpenEXR 3.2.3

Removed:

• mingw-w64-openexr25 is no longer available
• oiio-2.4.13.0-thread-shutdown.patch be removed

going to merge

[TodicaIonut]

It looks to be caused by the oiio-2.4.13.0-thread-shutdown.patch. You should be able to remove this patch since you are updating to 2.5.7, but you need to make sure that code in the openfx-io plugin still calls default_thread_pool_shutdown() when the plugin is unloaded.

done updating.