Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows installer build by removing libboost DLLs #1003

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

acolwell
Copy link
Collaborator

@acolwell acolwell commented Oct 2, 2024

Msys2 has updated to a version of boost that no longer includes the libboost-regex-mt and libboost-system-mt DLLs. This change removes references to these DLLs so that the installer build stops trying to find them and failing.

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes the Windows installer build by removing 2 boost DLLs that are no longer included in Msys2.

Have you tested your changes (if applicable)? If so, how?

Yes. I verified the Windows installer successfully builds again (https://github.com/acolwell/Natron/actions/runs/11138194808)

Msys2 has updated to a version of boost that no longer includes
the libboost-regex-mt and libboost-system-mt DLLs. This change
removes references to these DLLs so that the installer build
stops trying to find them and failing.
@acolwell acolwell merged commit f7a0345 into NatronGitHub:RB-2.6 Oct 2, 2024
3 checks passed
@acolwell acolwell deleted the remove_libboostregexmt_dll branch October 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants