Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
It fixes a few crashes caused by null cache pointers if an error occurs early in Natron startup. This change simply avoids dereferencing these null pointers so that Natron can exit cleanly without crashing.
Have you tested your changes (if applicable)? If so, how?
Yes. The crashes were easy to reproduce when an error occurs trying to initialize the python bindings or building with NATRON_RUN_WITHOUT_PYTHON. I know these aren't the common build/run situations, but the fix is trivial and it helps avoid early startup errors from being masked by null pointer exceptions. With these changes I've verified that Natron exits cleanly when errors in python initialization occur.