-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A page for individual element flowcells #876
base: master
Are you sure you want to change the base?
A page for individual element flowcells #876
Conversation
I'm not in a position to complain 😅 |
<th class="sort searchable" data-sort="start_date">Start date</th> | ||
<th class="sort searchable" data-sort="run_name">Run name</th> | ||
<th class="sort searchable" data-sort="run_type">Run type</th> | ||
<th class="sort searchable" data-sort="side">Side</th> | ||
<th class="sort searchable" data-sort="cycles">Cycles</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not adding the searchable
class to Outcome
deliberate(line 32)? It doesn't have the search box at present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. There's no search boxes anywhere neither on this page nor on the Illumina one. So maybe just remove the searchable tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I looked at the wrong page. I'll fix the list of flowcells in another PR.
} else { | ||
barcode_str += "N/A" | ||
} | ||
|
||
if (sample.hasOwnProperty("I2") && sample["I2"] !== ""){ | ||
barcode_str += "+" + sample["I2"]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there will never be a case where I2 exists without I1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. I guess it will look a bit weird in that case with N/A+GATATCGA
for example. But I guess if it's rare that could be ok? Or did you mean something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Added a couple of comments. Also:
- The list of undetermined indexes is very long. Maybe 20 like for Illumina is enough?
- Project name is missing in the table in the
Lane Stats (Pre-demultiplex)
tab
@ssjunnebo, The list of undetermined indices can now be expanded 5 at a time. Hope that's ok? Also, the project name should now be possible to show in the pre-demultiplex tab. However, the project ID for the example flowcell is wrong (lims-stage) so it's not visible on that one. |
Very fancy! I'm happy with that 😄
Would it be better to show the project ID instead on N/A if this is the case? |
Good idea! And it was easy as well! |
Should this be applied on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
OK, this became a bit bigger than I first anticipated.
I'll save an update of the flowcells list to another PR.