Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CellRanger multi support for GEX+VDJ (tested case: gex + vdj-t + vdj-b) #4

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

glrs
Copy link
Collaborator

@glrs glrs commented Oct 15, 2024

This pull request includes several changes to improve the robustness and functionality of the run_sample.py script in the lib/realms/tenx directory. The changes focus on ensuring default values for configurations, refining the generation of required files, and enhancing the command assembly logic.

Improvements to Default Values and Initialization:

Enhancements to File Generation:

  • lib/realms/tenx/run_sample.py: Refined the process method to dynamically generate required files based on a files_to_generate configuration.
  • lib/realms/tenx/run_sample.py: Split the generate_libraries_csv method into collect_libraries_data and generate_libraries_csv for better modularity and ensured directory creation before file writing. collect_libraries_data also used in generate_multi_sample_csv.
  • lib/realms/tenx/run_sample.py: Implemented the generate_multi_sample_csv method to generate the multi-sample CSV file based on pipeline information and configuration.

Command Assembly Logic:

  • lib/realms/tenx/run_sample.py: Improved the assemble_cellranger_command method by logging pipeline details, handling missing required arguments, and ensuring the output directory argument is always included. [1] [2]

Minor Logging Adjustments:

@glrs glrs merged commit f1c2ec4 into NationalGenomicsInfrastructure:main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant