Add exceptions for street-centerlines layer group to logic for hiding all layers #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zola ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an apparent bug in the "Toggle All Map Layers Off" functionality introduced in #1181 that was reported in helpscout ticket 3984. Toggling off all layer groups hides the
street-centerlineslayer group which is what renders the street names and widthsBecause there is no corresponding toggle for that layer in the layer palette, the only way the user can get them back is by clicking the "Toggle All Layers Back On" button. This code filters out that layer group so that it isn't hidden. Ideally we wouldn't hard code layer group ids into application code like this but, as things stand, there doesn't seem to be an easy way to distinguish layer groups with toggles in the layer palette from those without.