-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1544 New subscriber endpoint (part 1) #1545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TylerMatteo
requested changes
Oct 9, 2024
TylerMatteo
requested changes
Oct 15, 2024
TylerMatteo
requested changes
Oct 16, 2024
TylerMatteo
reviewed
Oct 16, 2024
TylerMatteo
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new endpoint to ZAP Search API that creates a new contact in SendGrid and adds that user to the List for the current ZAP Search environment.
New endpoint should exist as a
POST
to/subscribers
and take in a POST body with shape:List names are
zap-subscribers-staging
for staging andzap-subscribers-production
for production.Validation
The endpoint should perform the following validations on the supplied
POST
body and return the given error codesAdding subscriber
200
success response code.Once data is validated, the subscriber should be created and added to the list. See SendGrid docs for adding/updating a contact here. Note that request body can take in List IDs that the contact should be added to.
Note the following from SG's docs describing how contact creation is an asynchronous process:
Our endpoint should still be synchronous, so endpoint code may require implementing polling with a max wait time. Let's start with 3 seconds and see how fast SG's APIs are.
Completes #1544