Task/12835 upgrade node ember versions #1479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for labs-zap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… task/12835-upgrade-node-ember-versions
…YCPlanning/labs-zap-search into task/12835-upgrade-node-ember-versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates ZAP Search to use Node 16 and Ember 3.28
Multiple test errors outstanding still require resolution.
The most common is changing components to use angle brackets instead of curly brackets where necessary. I found this documentation helpful in resolving those.
Another common issue is the usage of the "action" helper. This is resolved by instead using the new "on" and "fn" helpers as documented here.
Others can vary from issues with inline styling to missing alt text on images.