Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sass 3 #1336

Merged
merged 7 commits into from
May 27, 2021
Merged

Remove sass 3 #1336

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
72fd965
Remove problematic settings file
May 26, 2021
27d1908
Remove labs-ui, foundation-sass, node-sass, etc. Copy legacy deps fro…
May 26, 2021
e34cc9b
remove test step
May 26, 2021
43cea68
Bump caniuse. remove autoprefixer configuration.
May 26, 2021
4121afa
Use concurrently for cleaner shutdowns
May 26, 2021
f3d73ca
Cleanup unnecessary or invalid files
May 26, 2021
43d0f0b
Merge branch 'develop' into remove-sass-3
allthesignals May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ package.json.ember-try

# OS
.DS_Store
/client/.yalc
5 changes: 2 additions & 3 deletions .husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
. "$(dirname "$0")/_/husky.sh"

cd client
yarn run test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

yarn run lint-staged

cd ../server
yarn run test
yarn run lint-staged
yarn run lint-staged
14 changes: 14 additions & 0 deletions client/app/components/labs-ui/site-header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import Component from '@ember/component';

export default Component.extend({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new new site-header, site-title component because you removed labs-ui?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@godfreyyeung yup it's the copied over version. see updated description for why

tagName: 'header',
classNames: ['site-header'],

ariaRole: 'banner',

closed: true,

responsiveNav: false,

responsiveSize: 'large',
});
5 changes: 5 additions & 0 deletions client/app/components/labs-ui/site-title.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import Component from '@ember/component';

export default Component.extend({
tagName: 'span',
});
Loading