Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Definitions of ZAP Updates" page to ZAP Search #1535

Open
TylerMatteo opened this issue Sep 23, 2024 · 7 comments
Open

Add "Definitions of ZAP Updates" page to ZAP Search #1535

TylerMatteo opened this issue Sep 23, 2024 · 7 comments
Assignees

Comments

@TylerMatteo
Copy link
Contributor

TylerMatteo commented Sep 23, 2024

Add new "Definition of ZAP Updates" page to ZAP Search.

Acceptance Criteria:

  • New page should match designs in Figma
  • New page should be at route /statuses
  • Link in "To sign up for ZAP updates, please visit here" should link to /subscribe (not implemented)
  • Page should only be reachable if SHOW_ALERTS feature flag is true.

Out of scope

  • Adding "Email Notifications" button to banner at top of the site

@TylerMatteo to follow up with @jessicashanshanhuang about mobile designs

@TylerMatteo
Copy link
Contributor Author

@dhochbaum-dcp That link should link to /subscribe, as in the full URL in prod would be zap.planning.nyc.gov/subscribe.

@dhochbaum-dcp
Copy link
Collaborator

dhochbaum-dcp commented Sep 30, 2024

Hi @jessicashanshanhuang, can you please take a look at https://deploy-preview-1537--labs-zap.netlify.app/statuses and let me know if the design is ok?

(The "subscribe" link is in the code, but since the page does not yet exist, the word linking it is not displaying)

@jessicashanshanhuang
Copy link

Hey @dhochbaum-dcp, looks great overall! I just have some minor suggestions with the spacing:

The spacing between the header and the "Definition of Zap Updates" should be increased, about 4rem.

Image

@jessicashanshanhuang
Copy link

Similarly, the gaps between each subsection should also be around 4rem to help distinguish the informational hierarchy.

Image

@jessicashanshanhuang
Copy link

For this text:

Image

Could we change the font size to 21px and have it bolded?

@dhochbaum-dcp
Copy link
Collaborator

@jessicashanshanhuang I've made those updates, please re-check and let me know if you approve.

@jessicashanshanhuang
Copy link

@dhochbaum-dcp Looks good to go 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants