Force fake null block to compare for radius filter

NYCPlanning · Apr 30, 2024 · bbc4950 · bbc4950
1 parent 3d3672b
commit bbc4950
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/server/src/project/geometry/geometry.service.ts b/server/src/project/geometry/geometry.service.ts
@@ -360,8 +360,6 @@ export class GeometryService {
   async getBlocksFromRadiusQuery(x, y, radius) {
     const queryForBlocks = QUERIES.blocksWithinRadius(x, y, radius);
     const distinctBlocks = `SELECT DISTINCT(block) FROM (${queryForBlocks}) blocksWithinRadius`;
-    // console.log("distinctBlocks", distinctBlocks);
-    // console.log("distinctblocks records", await this.carto.fetchCarto(queryForBlocks, "json", "post"))
     const blocks = await this.carto.fetchCarto(distinctBlocks, "json", "post");
 
     // note: DTM stores blocks with the borough

diff --git a/server/src/project/project.service.ts b/server/src/project/project.service.ts
@@ -250,8 +250,8 @@ export const generateFromTemplate = (query, template) => {
 };
 
 function generateProjectsFilterString(query) {
-  // Special handling for 'block' query, which must be explicitly ignored if empty
-  // otherwise, unmapped projects will be excluded from the results
+  // if blocks_in_radius is empty while the radius_filter is on, force api
+  // to match a non-existant block to return no projects. Otherwise delete attribute
   const radius_filter = query.distance_from_point && query.radius_from_point;
   if (!Object.keys(query.blocks_in_radius).length) {
     radius_filter ? query.blocks_in_radius = ['000000'] : delete query.blocks_in_radius