Upgrades ember-cli-sass #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swaps out node-sass for dart-sass
TylerMatteo
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
@allthesignals I'm going to approve and merge this. We're having some issues with the Applicant Portal FE that I think require a new labs-ui version. I'm going to merge these in and then make a few additional changes in a new branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps out node-sass for dart-sass
This PR addresses NYCPlanning/labs-zola#1058 by removing some friction with setup and installation stemming from the deprecated node-sass package.
I don't see CI on here but running
ember testlocally looks promising:A manual check of the kitchen sink page looks good as well.