Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

373 Sort Community Districts by Id #374

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

horatiorosa
Copy link
Contributor

Description

  • updated OpenAPI properties for CDs to include order variable
  • updated findMany to sort the CDs by id in ascending order
  • updated CD service spec to test communityDistricts order value is id

Tickets

Closes #373

Screenshot 2024-09-04 at 2 12 02 PM

@horatiorosa horatiorosa self-assigned this Sep 4, 2024
@horatiorosa horatiorosa requested a review from a team September 4, 2024 19:19
TangoYankee
TangoYankee previously approved these changes Sep 4, 2024
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

 - updated OpenAPI properties for CDs to include order variable
 - updated findMany to sort the CDs by id in ascending order
 - updated CD service spec to test communityDistricts order value is `id`
Copy link
Contributor

@pratishta pratishta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, SI districts are sorted, see that we're using Drizzle's asc

@horatiorosa horatiorosa merged commit 93f3572 into main Sep 5, 2024
3 checks passed
@horatiorosa horatiorosa deleted the issue-372-sort-district-numbers branch September 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort Community Districts
3 participants