Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

249 OpenAPI endpoint implementation findCapitalCommitmentsByManagingCodeCapitalProjectId #339

Conversation

horatiorosa
Copy link
Contributor

@horatiorosa horatiorosa commented Jul 3, 2024

Description

findCapitalCommitmentsByManagingCodeCapitalProjectId endpoint implementation
- Updated OpenAPI documentation to remove "under construction" emoji flag
Implement find capital commitments by managing code / capital project id id endpoint
- capital commitment by managing code capital project id controller, module, repository and service
- e2e and service unit tests

Tickets

Closes #249

@horatiorosa horatiorosa marked this pull request as draft July 3, 2024 17:20
@horatiorosa horatiorosa self-assigned this Jul 3, 2024
@horatiorosa horatiorosa force-pushed the 249-implement-findCapitalCommitmentsByManangingCodeCapitalProjectId-endpoint branch 5 times, most recently from 74b3f5d to 2de6d2a Compare July 10, 2024 19:03
@horatiorosa horatiorosa marked this pull request as ready for review July 10, 2024 19:07
@TangoYankee
Copy link
Member

TangoYankee commented Jul 12, 2024

Hello! I saw you added me as a co-author to the commit! Thank you ❤️

As we'll need to update the commit anyway to add the migrations, would you mind using the credentials linked to my GitHub? Gotta keep that stat streak alive!

tangoyankee <[email protected]>

Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration to apply the "pgTable" schema changes to the database

@horatiorosa horatiorosa force-pushed the 249-implement-findCapitalCommitmentsByManangingCodeCapitalProjectId-endpoint branch from 2de6d2a to 5a0ed4e Compare July 12, 2024 13:56
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme change isn't strictly necessary. I'm not withholding approval for it.

I do however still need to run the changes locally. I am doing that now.

README.md Outdated Show resolved Hide resolved
…odeCapitalProjectId

     - Updated OpenAPI documentation to remove "under construction" emoji glag

     Implement find capital commitments by managing code / capital project id id endpoint
     - cap com by mng code cap proj id controller, module, repository and service
     - e2e and service unit tests
     - added copy to README to add context regarding schema changes
Co-authored-by: horatio <[email protected]>
Co-authored-by: tangoyankee <[email protected]>
@horatiorosa horatiorosa force-pushed the 249-implement-findCapitalCommitmentsByManangingCodeCapitalProjectId-endpoint branch from 5a0ed4e to b541304 Compare July 12, 2024 14:34
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@horatiorosa horatiorosa merged commit 3ece7e5 into main Jul 12, 2024
3 checks passed
@horatiorosa horatiorosa deleted the 249-implement-findCapitalCommitmentsByManangingCodeCapitalProjectId-endpoint branch July 12, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement findCapitalCommitmentsByManagingCodeCapitalProjectId endpoint
2 participants