-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
250 Implement findCityCouncilDistricts endpoint #302
Merged
horatiorosa
merged 1 commit into
main
from
issue-250-find-city-council-districts-endpoint-implementation
Jun 4, 2024
Merged
250 Implement findCityCouncilDistricts endpoint #302
horatiorosa
merged 1 commit into
main
from
issue-250-find-city-council-districts-endpoint-implementation
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
from
May 30, 2024 16:08
63c0241
to
9f3d5dd
Compare
pratishta
reviewed
May 30, 2024
pratishta
requested changes
May 30, 2024
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
from
May 31, 2024 14:15
9f3d5dd
to
249b9e9
Compare
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
3 times, most recently
from
June 4, 2024 15:36
a680beb
to
a3a4995
Compare
TangoYankee
reviewed
Jun 4, 2024
TangoYankee
reviewed
Jun 4, 2024
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
from
June 4, 2024 16:24
a3a4995
to
c286175
Compare
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
from
June 4, 2024 16:26
c286175
to
e575e0b
Compare
TangoYankee
requested changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good. Next step would be to remove the construction emoji from the documentation because this PR implements it.
implement city council district (ccd) endpoint: - ccd controller, module, repository, service - cd unit and e2e tests - indentation fixes on openapi yaml - tweaks to README - regenerate ts and zod schemas Closes #250
horatiorosa
force-pushed
the
issue-250-find-city-council-districts-endpoint-implementation
branch
from
June 4, 2024 20:06
e575e0b
to
cbb7e0a
Compare
TangoYankee
approved these changes
Jun 4, 2024
pratishta
approved these changes
Jun 4, 2024
horatiorosa
deleted the
issue-250-find-city-council-districts-endpoint-implementation
branch
June 4, 2024 20:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implementation of city council district (ccd) endpoint
Tickets