Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

250 Implement findCityCouncilDistricts endpoint #302

Conversation

horatiorosa
Copy link
Contributor

Description

implementation of city council district (ccd) endpoint

  • ccd controller, module, repository, service
  • cd unit and e2e tests
  • indentation fixes on openapi yaml
  • tweaks to README
  • regen ts and zod schemas

Tickets

@horatiorosa horatiorosa self-assigned this May 30, 2024
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch from 63c0241 to 9f3d5dd Compare May 30, 2024 16:08
README.md Outdated Show resolved Hide resolved
@pratishta pratishta self-requested a review May 30, 2024 18:00
openapi/openapi.yaml Show resolved Hide resolved
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch from 9f3d5dd to 249b9e9 Compare May 31, 2024 14:15
@horatiorosa horatiorosa requested review from pratishta and a team May 31, 2024 14:21
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch 3 times, most recently from a680beb to a3a4995 Compare June 4, 2024 15:36
README.md Outdated Show resolved Hide resolved
compose.yaml Outdated Show resolved Hide resolved
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch from a3a4995 to c286175 Compare June 4, 2024 16:24
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch from c286175 to e575e0b Compare June 4, 2024 16:26
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good. Next step would be to remove the construction emoji from the documentation because this PR implements it.

implement city council district (ccd) endpoint:
 - ccd controller, module, repository, service
 - cd unit and e2e tests
 - indentation fixes on openapi yaml
 - tweaks to README
 - regenerate ts and zod schemas

Closes #250
@horatiorosa horatiorosa force-pushed the issue-250-find-city-council-districts-endpoint-implementation branch from e575e0b to cbb7e0a Compare June 4, 2024 20:06
@horatiorosa horatiorosa merged commit 67eb14f into main Jun 4, 2024
3 checks passed
@horatiorosa horatiorosa deleted the issue-250-find-city-council-districts-endpoint-implementation branch June 4, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement findCityCouncilDistricts endpoint
3 participants