Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document capital projects in city council district endpoint #299

Merged
merged 1 commit into from
May 30, 2024
Merged

Document capital projects in city council district endpoint #299

merged 1 commit into from
May 30, 2024

Conversation

bmarchena
Copy link
Contributor

@bmarchena bmarchena commented May 30, 2024 •
edited
Loading

Closes #242

Awaiting other endpoints.

TangoYankee
TangoYankee requested changes May 30, 2024
View reviewed changes
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Capital Project schema doesn't include 'category' in its list of required properties. It's a pre-existing issue and technically out of scope. But since this endpoint is affected, could you add it as part of this PR?

openapi/openapi.yaml Outdated Show resolved Hide resolved
@bmarchena bmarchena force-pushed the 242-capital-projects-in-council-district branch from 424b311 to dbd75a8 Compare May 30, 2024 14:19
TangoYankee
TangoYankee approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@TangoYankee TangoYankee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we've switched to emojis instead of the stable tag, you can merge whenever you're ready

@bmarchena bmarchena merged commit d6d9acc into main May 30, 2024
3 checks passed
@bmarchena bmarchena deleted the 242-capital-projects-in-council-district branch May 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TangoYankee TangoYankee TangoYankee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open API: document an endpoint for capital projects in a city council district
2 participants
@bmarchena @TangoYankee