generated from NYCPlanning/ae-remix-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capital project detail panel and connect it to route for single project #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerMatteo
force-pushed
the
16/select-project
branch
from
July 8, 2024 16:38
11b7568
to
8895640
Compare
TangoYankee
reviewed
Jul 8, 2024
app/routes/capital-projects.$managingCode.$capitalProjectId.tsx
Outdated
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 8, 2024
TangoYankee
reviewed
Jul 8, 2024
app/routes/capital-projects.$managingCode.$capitalProjectId.tsx
Outdated
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 8, 2024
app/components/CapitalProjectDetailPanel/CapitalProjectDetailPanel.tsx
Outdated
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 8, 2024
app/components/CapitalProjectDetailPanel/CapitalProjectDetailPanel.tsx
Outdated
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 8, 2024
app/components/CapitalProjectDetailPanel/CapitalProjectDetailPanel.tsx
Outdated
Show resolved
Hide resolved
TylerMatteo
force-pushed
the
16/select-project
branch
from
July 8, 2024 21:02
8895640
to
cef1779
Compare
This PR previously included an upgrade to |
TylerMatteo
force-pushed
the
16/select-project
branch
from
July 9, 2024 14:30
cef1779
to
83e17c4
Compare
The animation when expanding and shrinking the panel is a nice touch |
TangoYankee
reviewed
Jul 10, 2024
app/components/CapitalProjectDetailPanel/CapitalProjectDetailPanel.test.tsx
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 10, 2024
app/components/CapitalProjectDetailPanel/CapitalProjectDetailPanel.test.tsx
Show resolved
Hide resolved
TangoYankee
reviewed
Jul 10, 2024
TangoYankee
reviewed
Jul 10, 2024
TangoYankee
approved these changes
Jul 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16
Summary
This PR builds out the panel for showing project details for a single project. It uses the existing
/capital-projects/:managing-code/:capital-project-id
route.New dependencies
Date
class.Not included
There is one requirement in #16 not included here - the "fly to" functionality where the map moves to a bounding box of the selected project. I'm going to capture the issues I had implementing that in a separate Discussion or Issue and put forward some potential solutions and next steps.