Translate transform for pointclouds #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pushkalkatara <[email protected]>
Signed-off-by: pushkalkatara <[email protected]>
Signed-off-by: pushkalkatara <[email protected]>
|
The build is failing at weird error - /opt/conda/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:17:2: warning: #warning "Using deprecated NumPy API, disable it with " "#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
--
831 | #warning "Using deprecated NumPy API, disable it with " \
832 | ^
833 | imagecodecs/_aec.c:602:20: fatal error: libaec.h: No such file or directory
834 | compilation terminated.
835 | error: Setup script exited with error: command 'gcc' failed with exit status 1maybe adding |
|
Hi @pushkalkatara , I think the error that you faced might be due to recent numpy release, we fixed it in #262 can you rebase and force push ? |
…to translatePC
|
Thanks for pointing out @Caenorst Now the build is passing :D |
Caenorst
requested changes
May 16, 2020
Signed-off-by: pushkalkatara <[email protected]>
|
Hi @Caenorst Thanks for the detailed review. I have made some changes in the recent commit and added questions as well. please review once again. Thanks. |
Caenorst
reviewed
May 21, 2020
Signed-off-by: pushkalkatara <[email protected]>
|
Sorry, forgot to confirm the review :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #250