Add disableIMEXChannelCreation feature flag #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
reviewed
Oct 14, 2024
elezar
changed the title
klueska
reviewed
Oct 15, 2024
klueska
reviewed
Oct 15, 2024
klueska
reviewed
Oct 15, 2024
elezar
commented
Oct 16, 2024
internal/config/features.go
Outdated
| case FeatureGDRCopy: | ||
| return fs.GDRCopy.isEnabled(envvar, in...) | ||
| return fs.GDRCopy.isEnabledWithEnvvarOverride("NVIDIA_GDRCOPY", in...) | ||
| // Features without envvar overrides |
There was a problem hiding this comment.
Suggested change
| // Features without envvar overrides | |
| // Global features. | |
| // These cannot be set on a per-container bases and as such don't have envvar overrides |
elezar
commented
Oct 16, 2024
klueska
approved these changes
Oct 16, 2024
elezar
force-pushed
the
imex-default
branch
3 times, most recently
from
61f7dec
to
c9389e4
Compare
This change enables opt-in (off-by-default) features to be opted into. These features can be toggled by name by specifying the (repeated) --opt-in-features command line argument or as a comma-separated list in the NVIDIA_CONTAINER_TOOLKIT_OPT_IN_FEATURES environment variable. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a
disableIMEXChannelCreationfeature flag that allows the--no-create-imex-channelsoption added in NVIDIA/libnvidia-container#286 to be toggled.This allows IMEX channels to be exposed in environment where they are expected to be created up front.
See also NVIDIA/k8s-device-plugin#985