Update Go to 1.21.5 and k8s.io/* to 0.29.1 #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Emporopulo <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
reviewed
Feb 12, 2024
elezar
force-pushed
the
bump-go-and-k8s
branch
2 times, most recently
from
42154e6
to
b92bb7f
Compare
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
bump-go-and-k8s
branch
from
b92bb7f
to
bd1276c
Compare
Signed-off-by: Evan Lezar <[email protected]>
klueska
reviewed
Feb 12, 2024
| @@ -26,7 +26,7 @@ import ( | |||
| "k8s.io/apimachinery/pkg/watch" | |||
| "k8s.io/client-go/util/retry" | |||
| "k8s.io/klog/v2" | |||
| drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1alpha2" | |||
| drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1alpha3" | |||
There was a problem hiding this comment.
I didn't think we could make this change until we also made the kind changes. My expectation was that this PR would pull in the controller changes from #14 but not the kubelet-plugin changes. I'd also prefer to see this as a sparate commit, not bundled in the same commit as the go.mod changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also incorporates #14 to fix broken APIs.