Allow custom NVIDIA CTK path #72
Conversation
| - name: NVIDIA_CTK_PATH | ||
| value: "{{ .Values.nvidiaCtkPath }}" |
There was a problem hiding this comment.
Does this also require us to set a default in values.yaml?
There was a problem hiding this comment.
Also, is there a reason that this should be set at the root level of the values.yaml rather than specific to the kubelet plugin (same goes for .Values.nvidiaDriverRoot for that matter)?
There was a problem hiding this comment.
On:
Does this also require us to set a default in
values.yaml?
Thenvcdipackage will default to/usr/bin/nvidia-ctkif this is empty, but I would assume that an explicit entry invalues.yamlwould be better.
Also, is there a reason that this should be set at the root level of the
values.yamlrather than specific to the kubelet plugin (same goes for.Values.nvidiaDriverRootfor that matter)?
I think this depends on the API that the values file represents. I suppose from my perspective, the current options in the kubeletplugin section seem related to that pod specifically, whereas the driver root and this path are not specific to the plugin. Yes, they're currently only used there, but if another component is added here that requires these values where would be specify them then?
There was a problem hiding this comment.
Does this also require us to set a default in
values.yaml?
Good point. Fixed.
There was a problem hiding this comment.
Also, is there a reason that this should be set at the root level of the
values.yamlrather than specific to the kubelet plugin (same goes for.Values.nvidiaDriverRootfor that matter)?
Hmm, I can fix that. Where do they should go, in your opinion?
There was a problem hiding this comment.
@empovit I think this is probably more of a question for us internally than a serious issue with the PR.
@klueska do you want to block this PR on defining some other top-level structure to define these kinds of properties (driver, host?) or are you ok with leaving this as a top-level value for the time being?
There was a problem hiding this comment.
No, I think it's fine. Just an observation (but one that has implications on the user-facing API, so I want us to be conscious of what we are doing).
Signed-off-by: Vitaliy Emporopulo <[email protected]>
On OpenShift, the DTK and driver root paths must be overridden as follows: