Remove item when values are empty in map #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
requested changes
Jan 22, 2024
|
@kerthcet I see the linter is complaining due to imports and fmt errors. Once these are addressed it should be good to go. |
|
Actually I have no idea why this is failed but I changed the import as you did, can you help to approve this workflow, and see what will happen. @elezar |
kerthcet
force-pushed
the
cleanup/allocation
branch
from
bfdffa1
to
bca89f1
Compare
|
I have just created #49 so that you can run:
Locally to address this. |
elezar
approved these changes
Jan 23, 2024
|
Also, please just squash the changes into a single commit. |
Signed-off-by: kerthcet <[email protected]>
kerthcet
force-pushed
the
cleanup/allocation
branch
from
bca89f1
to
53f9c25
Compare
|
Done @elezar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @elezar