Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a tool for creating and updating svg demos #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a tool for creating and updating svg demos #116

wants to merge 1 commit into from

Conversation

yuanchen8911
Copy link
Collaborator

@yuanchen8911 yuanchen8911 commented May 8, 2024 •
edited
Loading

  1. Add a demo creation tool (copied from the KWOK project) that can run and record a demo in a svg format from a script. Thus, we can update a demo (a svg file) when a DRA script or configuration changes. To generate/update a demo, just run
make demo/specs/quickstart/basic-demo.svg
  1. Add the demo script file that was used to generate the current demo in the README file.
  2. Regenerate the svg demo file in README.

Note: this PR removes -it from the command docker exec -it "${KIND_CLUSTER_NAME}-worker" umount -R /proc/driver/nvidia in create-kind-cluster.sh because the demo creation script doesn't support TTY. The change won't affect the use of the script standalone.

@yuanchen8911
Add a demo svg file showing the baisc DRA use
3b5c528 
Update demo

Adjust demo svg format

Update svg format

Update the description of demo.

update

Signed-off-by: Yuan Chen <[email protected]>
Signed-off-by: Yuan Chen <[email protected]>

Update tje demo svg description

Signed-off-by: Yuan Chen <[email protected]>

Update the svg demo

Signed-off-by: Yuan Chen <[email protected]>

Remove duplicated info.

Signed-off-by: Yuan Chen <[email protected]>

Clean up

Signed-off-by: Yuan Chen <[email protected]>

Add a demo creation tool and udpate the demo

Signed-off-by: Yuan Chen <[email protected]>

Update the svg file
@yuanchen8911 yuanchen8911 changed the title Add a demo creation tool for creating and updating svg demo files Add a tool for automatically creating and updating svg demo files May 9, 2024
@yuanchen8911 yuanchen8911 changed the title Add a tool for automatically creating and updating svg demo files Add a tool for automatically creating and updating svg demos May 9, 2024
@yuanchen8911 yuanchen8911 changed the title Add a tool for automatically creating and updating svg demos Add a tool for creating and updating svg demos May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska Awaiting requested review from klueska

@elezar elezar Awaiting requested review from elezar

At least 1 approving review is required to merge this pull request.

Assignees

@yuanchen8911 yuanchen8911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yuanchen8911