Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added model support to test-maxtext.sh #971

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Conversation

kocchop
Copy link
Contributor

@kocchop kocchop commented Aug 1, 2024

Added more functionality to the test script:

  1. added more model support
  2. added parallelism heuristic
  3. added fp8 test support
  4. added example launch commands

…port, (2) added parallelism heuristic, (3) added fp8 test support (4) added example launch commands
Copy link
Collaborator

@nouiz nouiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments only.

.github/container/test-maxtext.sh Outdated Show resolved Hide resolved
.github/container/test-maxtext.sh Outdated Show resolved Hide resolved
.github/container/test-maxtext.sh Outdated Show resolved Hide resolved
.github/container/test-maxtext.sh Show resolved Hide resolved
@kocchop kocchop requested a review from nouiz August 1, 2024 21:07
@kocchop kocchop requested a review from sergachev August 2, 2024 19:41
@nouiz nouiz merged commit 3f6999e into main Aug 3, 2024
151 of 156 checks passed
@nouiz nouiz deleted the faysal/maxtext-test-script branch August 3, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants