Skip to content

Commit

Permalink
Improve TE test reporting, increase timeout (#1084)
Browse files Browse the repository at this point in the history
- Increase timeout as A100 tests take >1 hour to run
- Report the test failures/errors, not collection failures/errors
  • Loading branch information
olupton authored Oct 10, 2024
1 parent d1ff3c8 commit e8043a5
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -528,13 +528,14 @@ jobs:
STATISTICS_SCRIPT: |
summary_line=$(tail -n1 test-te.log)
errors=$(echo $summary_line | grep -oE '[0-9]+ error' | awk '{print $1} END { if (!NR) print 0}')
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "passed") | .outcome' | wc -l)
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "CollectReport" and .outcome == "failed") | .outcome' | wc -l)
passed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "passed") | .outcome' | wc -l)
failed_tests=$(cat pytest-report.jsonl | jq -r 'select(."$report_type" == "TestReport" and .when == "call" and .outcome == "failed") | .outcome' | wc -l)
total_tests=$((failed_tests + passed_tests))
echo "TOTAL_TESTS=${total_tests}" >> $GITHUB_OUTPUT
echo "ERRORS=${errors}" >> $GITHUB_OUTPUT
echo "PASSED_TESTS=${passed_tests}" >> $GITHUB_OUTPUT
echo "FAILED_TESTS=${failed_tests}" >> $GITHUB_OUTPUT
TIMEOUT_MINUTES: 120
ARTIFACTS: |
test-te.log
pytest-report.jsonl
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/_test_unit.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,18 @@ on:
type: string
description: 'Test artifacts to collect'
required: false
TIMEOUT_MINUTES:
type: number
description: 'Maximum test runtime, in minutes'
default: 60

jobs:
runner:
uses: ./.github/workflows/_runner_ondemand_slurm.yaml
with:
NAME: "A100"
LABELS: "A100,${{ github.run_id }}"
TIME: "01:00:00"
TIME: "${{ inputs.TIMEOUT_MINUTES }}:00"
secrets: inherit

run-unit-test:
Expand Down Expand Up @@ -67,6 +71,7 @@ jobs:
- name: Run tests
shell: bash -x -e {0}
continue-on-error: true
timeout-minutes: ${{ inputs.TIMEOUT_MINUTES }}
run: |
${{ inputs.EXECUTE }}
Expand Down

0 comments on commit e8043a5

Please sign in to comment.