fixups

NVIDIA · Aug 9, 2024 · d45131d · d45131d
1 parent cf984fe
commit d45131d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/container/jax_nsys/Analysis.ipynb b/.github/container/jax_nsys/Analysis.ipynb
@@ -498,7 +498,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "if len(comm_df):\n",
+    "if len(steady_state.communication):\n",
     "    fig, axs2d = plt.subplots(\n",
     "        ncols=3, figsize=[15, 5], squeeze=False, tight_layout=True\n",
     "    )\n",
@@ -647,7 +647,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "if len(comm_df):\n",
+    "if len(steady_state.communication):\n",
     "    fig, grid = plt.subplots(\n",
     "        nrows=len(top_module_ids), figsize=[15, 5], squeeze=False, tight_layout=True\n",
     "    )\n",

diff --git a/.github/container/jax_nsys/python/jax_nsys/jax_nsys/analysis.py b/.github/container/jax_nsys/python/jax_nsys/jax_nsys/analysis.py
@@ -100,7 +100,9 @@ def apply_warmup_heuristics(frames: ProfilerData) -> tuple[ProfilerData, Profile
     # expected to launch closer to in lockstep across processes.
     init = ProfilerData(compile=frames.compile)
     steady = ProfilerData()
-    steady_state_threshold = 1 if len(frames.communication) else 0
+    steady_state_threshold = (
+        1 if frames.communication is not None and len(frames.communication) else 0
+    )
     for k in ["communication", "thunk", "module"]:
         df = getattr(frames, k)
         if df is None: