Input device check #5631
Merged
Input device check #5631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [18307567]: BUILD STARTED |
|
CI MESSAGE: [18305355]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [18309171]: BUILD STARTED |
|
CI MESSAGE: [18309171]: BUILD FAILED |
|
CI MESSAGE: [18324189]: BUILD STARTED |
mdabek-nvidia
approved these changes
Sep 11, 2024
|
CI MESSAGE: [18324189]: BUILD FAILED |
mzient
added a commit
that referenced
this pull request
Sep 11, 2024
* Add experimental_exec_dynamic flag to Pipeline to enable new executor * Add DataNode.cpu() that triggers a GPU->CPU copy * Remove checks that prevented GPU->CPU transitions from Python and Pipeline class * Remove checks that prevented CPU operators from taking GPU inputs * Use old executor's graph lowering to run the checks * Add cpu->gpu tests * TODO: Improve input backend checks (#5631) * TODO: Add tensorflow support --------- Signed-off-by: Michal Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
input_device_check
branch
from
1b7aebc
to
6ad76f7
Compare
Signed-off-by: Michał Zientkiewicz <[email protected]>
mzient
commented
Sep 11, 2024
| bool has_shape_, has_dtype_; | ||
| DALIDataType dtype_; | ||
|
|
||
| bool has_const_value_ = false; | ||
| int const_value_ = 0; | ||
|
|
||
| const int kShapeLikeInputIdx = is_shape_like_ ? 0 : -1; |
There was a problem hiding this comment.
These are not compile-time kOnstants - just regular fields.
|
CI MESSAGE: [18338618]: BUILD STARTED |
|
CI MESSAGE: [18338618]: BUILD FAILED |
Signed-off-by: Michał Zientkiewicz <[email protected]>
|
CI MESSAGE: [18356254]: BUILD STARTED |
|
CI MESSAGE: [18356254]: BUILD FAILED |
jantonguirao
approved these changes
Sep 16, 2024
|
CI MESSAGE: [18433207]: BUILD STARTED |
jantonguirao
approved these changes
Sep 16, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Michal Zientkiewicz <[email protected]>
mzient
force-pushed
the
input_device_check
branch
from
fbb1b08
to
2e89b84
Compare
|
CI MESSAGE: [18433770]: BUILD STARTED |
|
CI MESSAGE: [18433770]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Check input device in OpSpec::AddInput. * Add `Any` and `MatchBackendOrCPU` input devices * Fix InputDevice in operators. Add Any device capability to "shape_like" inputs. * Add python-side backend validation in logical expressions. --------- Signed-off-by: Michal Zientkiewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR extends input device specification in OpSchema and adds input device validateion to OpSpec.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Some tests were modified.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A