Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Tiled at SRX beamline #315

Merged
merged 16 commits into from
Apr 8, 2024
Merged

Support for Tiled at SRX beamline #315

merged 16 commits into from
Apr 8, 2024

Conversation

dmgav
Copy link
Contributor

@dmgav dmgav commented Jan 31, 2024

Support for loading data from Tiled server at SRX beamline. Several minor fixes.

Issue to fix later: the arrays (Dask arrays) loaded from Tiled have NaNs in place of corrupt values. For example, if a row is missing 3 points in any positions, the last 3 elements of the respective array will be NaNs. PyXRF is currently replacing NaNs with zeros in fluorescent data and with median values for scalers. This is simple, but not the best approach, since this distorts the image. More intelligent handling of missing data should be implemented. Two options exist: replace full corrupt row with zeros (for fluorescence) and with median value (for scalers) or replace full corrupt row with one of the adjacent rows (both for fluorescence and the scalers).

Summary of Changes for Release Notes

Fixed

  • Compatibility with recent Numba: removed unsupported np.asarray function in the code compiled by Numba.

Added

  • New make_hdf parameter: catalog.
  • New pyxrf CLI parameter: --catalog-name or -c.
  • Extended support for loading corrupt data from Databroker for TES beamline.

Changed

Removed

How Has This Been Tested?

All new functionality was manually tested. PyXRF with changes is used at SRX and TES beamlines .

@dmgav dmgav merged commit eb44f27 into NSLS-II:master Apr 8, 2024
13 checks passed
@dmgav dmgav deleted the use-tiled branch April 8, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant