-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ideal air loads measure #221
Open
ChristopherCaradonna
wants to merge
10
commits into
main
Choose a base branch
from
ccaradon/euss_ideal_thermal_air_loads_revised
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update ideal air loads measure #221
ChristopherCaradonna
wants to merge
10
commits into
main
from
ccaradon/euss_ideal_thermal_air_loads_revised
+46,945
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the ideal air loads measure from developed in #193, but removes other unwanted changes.
eringold
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior comments from the other PR addressed, just a couple small things on the measure test.
resources/measures/upgrade_hvac_enable_ideal_air_loads/tests/measure_test.rb
Outdated
Show resolved
Hide resolved
resources/measures/upgrade_hvac_enable_ideal_air_loads/tests/measure_test.rb
Outdated
Show resolved
Hide resolved
eringold
approved these changes
Sep 23, 2024
eringold
reviewed
Sep 27, 2024
resources/measures/upgrade_hvac_enable_ideal_air_loads/measure.rb
Outdated
Show resolved
Hide resolved
resources/measures/upgrade_hvac_enable_ideal_air_loads/measure.rb
Outdated
Show resolved
Hide resolved
eringold
previously approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the ideal air loads measure from developed in #193, but removes other unwanted changes.
Pull request overview
Includes some updates based on PR comments, and address some OpenStudio Standards changes.
Pull Request Author: Chris CaraDonna
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File