Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cfe.py - remove QINSUR as default variable name mapping #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ben-Choat
Copy link
Contributor

When cfe is ran with PET (PET->CFE) QINSUR is not an output file of PET and including this as a default mapping breaks the calibration either immediately or after the first iteration when the ngen configuration file (e.g., Realization_pet_cfe_calibNC.json) is updated.

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux
  • MacOS

When cfe is ran with PET (PET->CFE) QINSUR  is not an output file of PET and including this as a default mapping breaks the calibration either immediately or after the first iteration when the ngen configuration file (e.g., Realization_pet_cfe_calibNC.json) is updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant