Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent.py - fixes #85 #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ben-Choat
Copy link
Contributor

Added a second call to workdir in JobMeta under if self._job is None in class Agent()

[Short description explaining the high-level reason for the pull request]

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Linux
  • MacOS

Added a second call to workdir in JobMeta under if self._job is None in class Agent()
@hellkite500
Copy link
Member

The intended semantics the way the code exists is that the workdir passed in becomes the parent directory under which a new, temporary directory is created as the workdir see here.

I'm not seeing the direct need for forcing the workdir for all agents for all runs to be the same here. The intention with the default behavior was to allow a set of runs/agents to operate out of a common parent directory without conflicting with out runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants