Shared param test #180
Open
Shared param test #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
force-pushed
the
shared-param-test
branch
2 times, most recently
from
ae06396
to
f5c7f72
Compare
hellkite500
force-pushed
the
shared-param-test
branch
from
f5c7f72
to
a9e2f50
Compare
Open
hellkite500
commented
Sep 1, 2024
| else: | ||
| p = params.get(name, []) | ||
| df = pd.DataFrame([s.__dict__ for s in p]) | ||
| df['model'] = name | ||
| df.rename(columns={'name':'param'}, inplace=True) | ||
| return df | ||
| return df.set_index('param') |
There was a problem hiding this comment.
Ugh. It is actually possible for this dataframe to be empty if called from _map_params_to_realization and there is a module in the realization which doesn't have any params from the config to map to it, in this case, the set_index here will fail
There was a problem hiding this comment.
Also, I think this breaks search, since param is no longer a column when subset to update_config
search.py", line 168, in dds_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test to validate that the ngen module
_params_as_dfwill ensure that any parameters with the same name end up mapping to the same permuted value.