Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type check import shapely.geometry.Point #28

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 3, 2023

fixes #25

Additions

  • Add a missing type check import shapely.geometry.Point to the nwis_location module.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@aaraney aaraney requested a review from robertbartel July 3, 2023 17:28
@aaraney
Copy link
Member Author

aaraney commented Jul 3, 2023

@robertbartel, given that this just fixes a linting error, im not going to do a version bump. I think it is safe to implicitly include this in 0.0.2. Thoughts?

Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertbartel, given that this just fixes a linting error, im not going to do a version bump. I think it is safe to implicitly include this in 0.0.2. Thoughts?

I think that's fine here. I'm not sure whether it would be safe in general, but given the maturity and breadth of usage for this package currently, I'm not going to spend the time trying to think up an obscure counterexample.

@aaraney aaraney merged commit 8ae3cf2 into NOAA-OWP:master Jul 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing github actions
2 participants