Correcting incorrect Tuple type hints #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correcting typing hints declaring use of Tuple['T'] (for some T) but intending a tuple having any number of T objects (i.e. Tuple['T', ...].
Correcting typing hints declaring use of Tuple['T'] (for some T) but intending a tuple having any number of T objects (i.e. Tuple['T', ...].
aaraney
previously approved these changes
Jul 3, 2023
|
@aaraney, this needs a quick re-review. I didn't bump the package's version previously. |
aaraney
approved these changes
Jul 3, 2023
|
Not sure why the test runners are failing. Having had a look at the list of available python interpreter versions, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing occurrences of
Tuple['T']withTuple['T', ...]as appropriate.Closes #23.