Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set definitions for what Django and Pandas versions to use #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

christophertubbs
Copy link
Contributor

We ran into an issue the other day where imported dependencies were dictating that old versions should be used. I updated some of the version definitions to ensure that more modern versions of Pandas and Django are used.

@christophertubbs christophertubbs added the dependencies Pull requests that update a dependency file label Jul 20, 2023
@robertbartel robertbartel added the maas MaaS Workstream label Jul 21, 2023
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in a vacuum, I'd prefer moving to Pandas 2.0, but I don't think we actually are compelled to at the moment (correct me if I'm wrong @christophertubbs). On the other hand, we do have a transitive dependency on an earlier version of Pandas pending with #394.

We could either leave this as blocked (until NOAA-OWP/ngen-cal#57 is addressed) or modify the Pandas version specified here to be something compatible with ngen-cal. Thoughts?

@robertbartel
Copy link
Contributor

For now, I'm moving this to Blocked while we wait on the aforementioned ngen-cal issue.

@aaraney
Copy link
Member

aaraney commented Aug 4, 2023

@christophertubbs, @robertbartel, im blocking off time on Monday to investigate the ngen-cal issue (NOAA-OWP/ngen-cal#57). Ill report back on this after im done with that.

@aaraney
Copy link
Member

aaraney commented Sep 8, 2023

Still waiting for NOAA-OWP/ngen-cal#64 to be reviewed and then this should be unblocked.

@aaraney
Copy link
Member

aaraney commented Nov 21, 2023

NOAA-OWP/ngen-cal#64 has been merged. Moving this to todo, now that this is unblocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maas MaaS Workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants