Add switch for each executable not to compile unnecessary executables #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chan-hoo
requested review from
christinaholtNOAA,
christopherwharrop-noaa,
chunhuazhou,
daviddowellNOAA,
guoqing-noaa and
hu5970
as code owners
7 tasks
guoqing-noaa
reviewed
Dec 2, 2023
CMakeLists.txt
Outdated
| endif() | ||
| if(USE_RAPHRRR_SFC) | ||
| add_subdirectory(use_raphrrr_sfc.fd) | ||
| endif() |
There was a problem hiding this comment.
@chan-hoo Thanks a lot for making these changes!! A function we've been waiting for!
I have a comment to add a top-level option such as "RRFS_UTL_ALL" which can turn on/off building all executables except those explicitly set in the cmake command line.
Changes are in this PR to your fork:
chan-hoo#1
There was a problem hiding this comment.
@guoqing-noaa, thanks for the PR. Merged.
There was a problem hiding this comment.
@chan-hoo Thanks for merging the changes!
patch to feature/switch
|
@hu5970 and @chunhuazhou Please review this PR at your earlier convenience. Thanks! |
hu5970
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
CMakeLists.txt.TESTS CONDUCTED:
Build test in the RRFS workflow (EMC)
ISSUE (optional):
Fixes issue mentioned in #55