Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple time blocks #62

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Multiple time blocks #62

merged 5 commits into from
Jun 18, 2024

Conversation

Geary-Layne
Copy link
Contributor

@Geary-Layne Geary-Layne commented May 22, 2024 •
edited
Loading

Linear Issue

IDSSE-538

Changes

  • Change schema to support multiple time blocks
    • validDt is now a list
    • each time object must be a dictionary with either 'start'/'end' or 'times' (for single or explicit list)
  • Updated datetime string in test files to be iso

Explanation

I believe this could break other repo as there non-backward compatible changes to the schemas

@Geary-Layne Geary-Layne self-assigned this May 22, 2024
@paulhamer-noaa
Copy link
Contributor

The event portfolios in this check are inconsistent with the schema validation?

paulhamer-noaa
paulhamer-noaa requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@paulhamer-noaa paulhamer-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UAT Event Portfolio examples appear to be incorrect?

@paulhamer-noaa paulhamer-noaa merged commit 2916057 into main Jun 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhamer-noaa paulhamer-noaa paulhamer-noaa requested changes

@mackenzie-grimes-noaa mackenzie-grimes-noaa mackenzie-grimes-noaa approved these changes

Assignees

@Geary-Layne Geary-Layne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geary-Layne @paulhamer-noaa @mackenzie-grimes-noaa