tools/fv_io: fix a few minor errors #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ables to .false. when files are closed
bensonr
approved these changes
Sep 13, 2023
laurenchilutti
added a commit
to laurenchilutti/GFDL_atmos_cubed_sphere
that referenced
this pull request
Sep 22, 2023
…ables to .false. when files are closed (NOAA-GFDL#284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing else statement in fv_io.
Also noticed that some of the *_is_open variables (which should be set to false when closing the file) were not explicitly set to false. So this also includes a few of these fixes.
Fixes #282 (this change needs to be pulled into dev/emc, dev/gfdl and dev/gfdl_am5)
How Has This Been Tested?
Tested on gaea C5 with SHiELD_build RTS and CI tests.
Checklist:
Please check all whether they apply or not