update yaml parser to read in arrays and output them #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensonr
reviewed
Aug 20, 2024
diag_manager/diag_yaml_format.md
Outdated
| @@ -43,14 +43,14 @@ diag_files: | |||
| ### 2.1 Global Section | |||
| The diag_yaml requires “title” and the “baseDate”. | |||
| - The **title** is a string that labels the diag yaml. The equivalent in the legacy diag_table would be the experiment. It is recommended that each diag_yaml have a separate title label that is descriptive of the experiment that is using it. | |||
| - The **basedate** is an array of 6 integers indicating the base_date in the format [year month day hour minute second]. | |||
| - The **basedate** is an array of 6 integers indicating the base_date in the format [year, month, day, hour, minute, second]. | |||
There was a problem hiding this comment.
Do you want to make it clear that it is a comma-separated array to help contrast from the original space-separated format?
There was a problem hiding this comment.
Yes good idea, added that with c496f38, along with a note that spacing is not significant.
That commit also updates the rest of the test scripts to use the new base date format since they were missed originally.
bensonr
approved these changes
Aug 20, 2024
|
closing, yaml schema changes were reverted. We're just going to go with the old format for base_date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the yaml parser to be able to read in arrays as the base date for the new diag yaml format. It just converts any yaml format arrays to a space-separated string at the read in time, so the old format will still work as well.
Also makes updates to be able to output them when writing the output yaml file. Right now it only checks if the second value in a yaml block is an array (since thats where the base date will be) but if preferable I can add the check for every value written.
How Has This Been Tested?
gcc and oneapi on the amd box
Checklist:
make distcheckpasses