Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rocoto task names #2981

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update rocoto task names #2981

wants to merge 1 commit into from
+319 −319

Conversation

WalterKolczynski-NOAA
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA commented Oct 4, 2024 •
edited
Loading

Description

Updates the GEFS task names to include the $RUN so they are consistent with the task names in the GFS system. This is one step towards abstracting out common elements.

Also adds an underscore between the RUN and task name for all tasks to make them more readable.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Cycled test on Hercules
  • GEFS test on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • I have made corresponding changes to the system documentation if necessary

@WalterKolczynski-NOAA
Update rocoto task names
10f5e5b 
Updates the GEFS task names to include the `$RUN` so they are consistent
with the task names in the GFS system. This is one step towards unifying
the systems where possible.

Also adds an underscore between the RUN and task name for *all* tasks to
make them more readable.
@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Oct 4, 2024
@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Oct 4, 2024
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, nice QOL updates, thanks @WalterKolczynski-NOAA !

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

One feature request from this would be to have more logical ensemble metatask names. Since the task names include a number, it seems easy enough to just name the metatasks after the root name of the task (see comments). Would this be an easy add to this PR? If not, I'd be happy to open a follow-on issue.

workflow/rocoto/gfs_tasks.py
@@ -2680,7 +2680,7 @@ def _get_ecengroups():
'maxtries': '&MAXTRIES;'
}

metatask_dict = {'task_name': f'{self.run}ecmn',
metatask_dict = {'task_name': f'{self.run}_ecmn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something necessarily for this PR, but it would be nice to have simpler metatask names, like f'{self.run}_ecen'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improving the task names is planned as a next step.

workflow/rocoto/gfs_tasks.py
@@ -2851,7 +2851,7 @@ def _get_eposgroups(epos):
'maxtries': '&MAXTRIES;'
}

metatask_dict = {'task_name': f'{self.run}epmn',
metatask_dict = {'task_name': f'{self.run}_epmn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto, epos.

workflow/rocoto/gfs_tasks.py
@@ -2890,7 +2890,7 @@ def earc(self):
'maxtries': '&MAXTRIES;'
}

metatask_dict = {'task_name': f'{self.run}eamn',
metatask_dict = {'task_name': f'{self.run}_eamn',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earc.

aerorahul
aerorahul approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @DavidHuber-NOAA said.
An alternative/extension, e.g. eamn -> earcmn to go with earc#grp#

@WalterKolczynski-NOAA
Copy link
Contributor Author

When I do come to updating the task names, it's going to be to real words like recenter or archive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerorahul aerorahul aerorahul approved these changes

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

Assignees
No one assigned
Labels
CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WalterKolczynski-NOAA @aerorahul @KateFriedman-NOAA @DavidHuber-NOAA @emcbot