Update global jdas enkf diag job with COMIN/COMOUT for COM prefix

[mingshichen-noaa]

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global jdas enkf diagnostics job.

Refs #2451

Type of change

• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO

How has this been tested?

• Clone and build on RDHPCS
• Cycled tests on Hercules
• Forecast-only tests on Hercules

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing tests pass with my changes
• I have made corresponding changes to the documentation if necessary

[KateFriedman-NOAA]

Changes look ok for the most part but some COMOUTs needs to be changed to COMINs.

[mingshichen-noaa]

@KateFriedman-NOAA
Thank you very much for your comments. Based on your suggestions. I have changed "COMOUT_ATMOS_ANALYSIS_DET_PREV" into "COMIN_ATMOS_ANALYSIS_DET_PREV".

[KateFriedman-NOAA]

Requested updates alongside other updates look good, thanks @mingshichen-noaa !

[emcbot]

CI Update on Wcoss2 at 09/27/24 05:05:09 AM
============================================
Cloning and Building global-workflow PR: 2959
with PID: 52099 on host: clogin03

[emcbot]

Automated global-workflow Testing Results:

Machine: Wcoss2
Start: Fri Sep 27 05:11:33 UTC 2024 on clogin03
---------------------------------------------------
Build: Completed at 09/27/24 05:49:22 AM
Case setup: Completed for experiment C48_ATM_c55c8630
Case setup: Skipped for experiment C48mx500_3DVarAOWCDA_c55c8630
Case setup: Skipped for experiment C48_S2SWA_gefs_c55c8630
Case setup: Completed for experiment C48_S2SW_c55c8630
Case setup: Completed for experiment C96_atm3DVar_extended_c55c8630
Case setup: Skipped for experiment C96_atm3DVar_c55c8630
Case setup: Completed for experiment C96C48_hybatmaerosnowDA_c55c8630
Case setup: Completed for experiment C96C48_hybatmDA_c55c8630
Case setup: Completed for experiment C96C48_ufs_hybatmDA_c55c8630

[emcbot]

Experiment C96C48_hybatmDA_c55c8630 FAIL on Wcoss2 at 09/27/24 06:42:30 AM

Error logs:

/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/logs/2021122100/gdasanaldiag.log

Follow link here to view the contents of the above file(s): (link)

[WalterKolczynski-NOAA]

JGDAS_ATMOS_ANALYSIS_DIAG also uses the exglobal_diag.sh script, so they have to be updated at the same time.

+ JGDAS_ATMOS_ANALYSIS_DIAG[30]: declare_from_tmpl -rx COM_ATMOS_ANALYSIS
+ bash_utils.sh[35]: [[ NO == \N\O ]]
+ bash_utils.sh[35]: set +x
declare_from_tmpl :: COM_ATMOS_ANALYSIS=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/gdas.20211221/00//analysis/atmos
+ JGDAS_ATMOS_ANALYSIS_DIAG[31]: mkdir -m 775 -p /lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/RUNTESTS/COMROOT/C96C48_hybatmDA_c55c8630/gdas.20211221/00//analysis/atmos
+ JGDAS_ATMOS_ANALYSIS_DIAG[35]: /lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/scripts/exglobal_diag.sh
Begin exglobal_diag.sh at Fri Sep 27 06:36:46 UTC 2024
++ exglobal_diag.sh[25]: pwd
+ exglobal_diag.sh[25]: pwd=/lfs/h2/emc/stmp/terry.mcguinness/RUNDIRS/C96C48_hybatmDA_c55c8630/gdas.2021122100/analdiag.246715
+ exglobal_diag.sh[28]: CDATE=2021122100
+ exglobal_diag.sh[29]: GDUMP=gdas
+ exglobal_diag.sh[32]: export 'CHGRP_CMD=chgrp rstprod'
+ exglobal_diag.sh[32]: CHGRP_CMD='chgrp rstprod'
+ exglobal_diag.sh[33]: export NCLEN=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/ush/getncdimlen
+ exglobal_diag.sh[33]: NCLEN=/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/ush/getncdimlen
+ exglobal_diag.sh[34]: export CATEXEC=/apps/ops/prod/libs/intel/19.1.3.304/cray-mpich/8.1.4/ncdiag/1.0.0/bin/ncdiag_cat_serial.x
+ exglobal_diag.sh[34]: CATEXEC=/apps/ops/prod/libs/intel/19.1.3.304/cray-mpich/8.1.4/ncdiag/1.0.0/bin/ncdiag_cat_serial.x
+ exglobal_diag.sh[35]: COMPRESS=gzip
+ exglobal_diag.sh[36]: UNCOMPRESS=gunzip
+ exglobal_diag.sh[37]: APRUNCFP='mpiexec -l -np $ncmd --cpu-bind verbose,core cfp'
+ exglobal_diag.sh[40]: netcdf_diag=.true.
+ exglobal_diag.sh[41]: binary_diag=.false.
+ exglobal_diag.sh[44]: RUN=gdas
+ exglobal_diag.sh[45]: SENDECF=NO
+ exglobal_diag.sh[46]: SENDDBN=NO
+ exglobal_diag.sh[51]: export APREFIX=gdas.t00z.
+ exglobal_diag.sh[51]: APREFIX=gdas.t00z.
/lfs/h2/emc/global/noscrub/globalworkflow.ci/GFS_CI_ROOT/PR/2959/global-workflow/scripts/exglobal_diag.sh: line 52: COMOUT_ATMOS_ANALYSIS: unbound variable