Refactor NRL h2o photochemical scheme #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dustinswales I'm not seeing a UFS WM PR for this. Shouldn't there be one? Or were you expecting this to get combined with something since it doesn't change results? |
|
@grantfirl I will update my branches and open a PR into UWM. |
…ture/refactor_h2ophys
…wales/fv3atm into feature/refactor_h2ophys
…ture/refactor_h2ophys
…wales/fv3atm into feature/refactor_h2ophys
14 tasks
grantfirl
reviewed
Aug 22, 2024
| [thpsnmp_is_init] | ||
| standard_name = flag_for_thompson_mp_scheme_initialization | ||
| long_name = flag carrying scheme initialization status | ||
| units = flag |
There was a problem hiding this comment.
@dustinswales FYI, this variable is missing the required dimensions attribute. I'm currently running RTs for a combined PR for this and Lisa's, so you probably don't need to fix anything since it is already fixed in the combined branch. I'm only commenting in case we can't keep the combination for some reason.
|
@jkbk2004 @dustinswales This can be closed since it is combined into #865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Included in this PR are changes to NRL's stratospheric h2o photochemistry scheme to make it "safe across multiple CCPP instances". These changes are identical to the reorganization that o3 photochemistry scheme underwent in the fall of 2023..
Both schemes are called from a new module, GFS_photochemistry, at the start of the time-split section of the suite. Previously, the ozone scheme was called from GFS_stateout_update, and the h2o scheme was called just after.
Issue(s) addressed
N/A
Testing
No changes to RT's on Hera with Intel
Dependencies